Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

659 create lyche about us page #665

Merged
merged 10 commits into from
Sep 21, 2023
Merged

659 create lyche about us page #665

merged 10 commits into from
Sep 21, 2023

Conversation

Snorre98
Copy link
Contributor

@Snorre98 Snorre98 commented Sep 5, 2023

No description provided.

@Snorre98 Snorre98 linked an issue Sep 5, 2023 that may be closed by this pull request
Create Lyche "about us" page #659
Closed
@Snorre98 Snorre98 marked this pull request as ready for review September 5, 2023 20:35
Snorre98
Snorre98 commented Sep 6, 2023
View reviewed changes
Copy link
Contributor Author

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for myself

frontend/src/Components/SultenCard/SultenCard.module.scss Show resolved Hide resolved
frontend/src/Components/SultenCard/SultenCard.module.scss Show resolved Hide resolved
frontend/src/Components/SultenCard/SultenCard.tsx Outdated Show resolved Hide resolved
frontend/src/Pages/LycheAboutPage/LycheAboutPage.module.scss Show resolved Hide resolved
frontend/src/assets/diggf4353.jpg Outdated Show resolved Hide resolved
emilte
emilte approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@emilte emilte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du må gjerne dele opp i mindre oppgaver så det ikke er så mye i review. Man kan fint merge mange brancher dagen lism. Anbefaler å jobbe tett mot master hele tiden.

@Snorre98 Snorre98 force-pushed the 659-create-lyche-about-us-page branch from 19097ba to 550e8a3 Compare September 21, 2023 17:36
@Snorre98 Snorre98 merged commit cda9593 into master Sep 21, 2023
4 checks passed
@Snorre98 Snorre98 deleted the 659-create-lyche-about-us-page branch September 21, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinKristiansen KevinKristiansen KevinKristiansen left review comments

@emilte emilte emilte approved these changes

@evgiz evgiz Awaiting requested review from evgiz

Assignees

@Snorre98 Snorre98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Lyche "about us" page
3 participants
@Snorre98 @KevinKristiansen @emilte